Support DEX orders on stellar client#119
Conversation
zaelgohary
left a comment
zaelgohary
left a comment
There was a problem hiding this comment.
Please fix analyze workflow. Also, can you replace prints with logger?
zaelgohary
left a comment
zaelgohary
left a comment
There was a problem hiding this comment.
I get insufficient balance although I have enough XLMs in my balance.
Also, USDC asset code is not added while adding trustline,
Logger is not working. I had to edit the logger value in client to the following for it to print.
var logger = Logger(
printer: PrettyPrinter(
methodCount: 2,
errorMethodCount: 8,
lineLength: 120,
colors: true,
printEmojis: true,
),
level: Level.debug,
filter: ProductionFilter(),
);
zaelgohary
left a comment
zaelgohary
left a comment
There was a problem hiding this comment.
Although I create an order successfully, I get an empty list when listing offers.
|
I get the following error while updating the order.
|
|
|
…dk-dart into development_order_book
…rs/tfgrid-sdk-dart into development_order_book
There was a problem hiding this comment.
- Can we add Docs to the PR? Please, don't forget to handle the units we use in creating/updating orders.
- When creating order with price '.0001; I get the following err: (It leads the leading 0. Needs to be mentioned in the docs)
- When creating account through threefold service on Testnet, it failed to add USDC asset.
- Amount before and after create order does not match the price
- I created 4 offers, none of them were listed in the orderbook
Total selling amount = Buy amount * price
price = 1 / price |
|
zaelgohary
left a comment
zaelgohary
left a comment
There was a problem hiding this comment.
Good job, @AlaaElattar!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #119 +/- ##
==============================================
Coverage ? 62.78%
==============================================
Files ? 26
Lines ? 1177
Branches ? 0
==============================================
Hits ? 739
Misses ? 438
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 participants
Description
Changes
createOrder, user can create buy/sell orders for specific assets.cancelOrder, user can cancel specific order with its id.getOrderBook, user can get oder book of the conversion between any 2 assets.listMyOffers, user can list its offers.updateOrder, user can update an existing offer with its id.Related Issues
#112
Checklist